Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(op-test-vectors): Remove Logs Hash #49

Merged
merged 1 commit into from
Jul 27, 2024
Merged

fix(op-test-vectors): Remove Logs Hash #49

merged 1 commit into from
Jul 27, 2024
+0 −6

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jul 27, 2024

Description

Since the receipts_root commits to the logs, we don't need the logs_hash in the ExecutionResult.

Metadata

Fixes #48

@refcell refcell added A-op-test-vectors Area: op-test-vectors crate K-fix Kind: Fix labels Jul 27, 2024
@refcell refcell self-assigned this Jul 27, 2024
0xOsiris
0xOsiris approved these changes Jul 27, 2024
View reviewed changes
Copy link
Contributor

@0xOsiris 0xOsiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I completely agree 🚢

@0xOsiris 0xOsiris merged commit 0736d06 into main Jul 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xOsiris 0xOsiris 0xOsiris approved these changes

@0xKitsune 0xKitsune Awaiting requested review from 0xKitsune

Assignees

@refcell refcell

Labels
A-op-test-vectors Area: op-test-vectors crate K-fix Kind: Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(opt8n): Log Root Calculation
2 participants
@refcell @0xOsiris